optimize hash implementations
#559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/optimize-hash
branch
3 times, most recently
from
eb1ca9e to
457bca7
Compare
This optimizes the `hash` implementation added in #452. Creating tuples with statically unknown types that may hold random values at runtime should be avoided for performance reasons. As a result, the allocation regression reported in #558 has been reduced to the previous level, although the time regression from `hash` calculation still remains.
aviatesk
force-pushed
the
avi/optimize-hash
branch
from
457bca7 to
f57460b
Compare
Member
|
I don't think we really need to hash down the whole tree - the important thing is that equal green nodes have equal hashes (while not being too collide-y). I would propose we hash the length of the children and the (kinds/# of children) of the first child, but do not recurse to the second level. |
c42f
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
This optimizes the `hash` implementation added in JuliaLang/JuliaSyntax.jl#452. Creating tuples with statically unknown types that may hold random values at runtime should be avoided for performance reasons. As a result, the allocation regression reported in JuliaLang/JuliaSyntax.jl#558 has been reduced to the previous level, although the time regression from `hash` calculation still remains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the
hashimplementation added in#452. Creating tuples with statically unknown types that may hold random values at runtime should be avoided for performance reasons. As a result, the allocation regression reported in #558 has been reduced to the previous level, although the time regression from
hashcalculation still remains.